Skip to content

Fix/update collection dto partial#423

Open
AnneGerlach wants to merge 3 commits intoIQSS:developfrom
nfdi4health:fix/update-collection-dto-partial
Open

Fix/update collection dto partial#423
AnneGerlach wants to merge 3 commits intoIQSS:developfrom
nfdi4health:fix/update-collection-dto-partial

Conversation

@AnneGerlach
Copy link
Copy Markdown

What this PR does / why we need it:

  • This PR relaxes the typing of the UpdateCollection use case to allow partial collection updates.

  • Native Dataverse collection updates do not require a fully populated object, only the fields to be changed need to be provided.

  • This change aligns the client typing with that behavior and avoids unnecessary TypeScript warnings in downstream usage.

  • This is a typing-only change with no runtime impact.

Which issue(s) this PR closes:

  • Closes -

Related Dataverse PRs:

  • Depends on -

Special notes for your reviewer:

  • TypeScript typing change only (Partial)

  • No API or runtime behavior changes

Suggestions on how to test this:

Is there a release notes or changelog update needed for this change?:

  • Yes, small changelog entry

Additional documentation:

@pdurbin pdurbin moved this to Ready for Triage in IQSS Dataverse Project Feb 17, 2026
@scolapasta scolapasta moved this from Ready for Triage to Ready for Review ⏩ in IQSS Dataverse Project Feb 17, 2026
@cmbz cmbz added FY26 Sprint 17 FY26 Sprint 17 (2026-02-11 - 2026-02-25) FY26 Sprint 18 FY26 Sprint 18 (2026-02-25 - 2026-03-11) labels Feb 25, 2026
@cmbz cmbz added this to the 6.11 milestone Mar 11, 2026
@cmbz cmbz added the FY26 Sprint 20 FY26 Sprint 20 (2026-03-26 - 2026-04-08) label Mar 27, 2026
@ChengShi-1 ChengShi-1 self-assigned this Apr 3, 2026
@ChengShi-1 ChengShi-1 self-requested a review April 3, 2026 02:34
Copy link
Copy Markdown
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the change and your contribution. This is a good point. I tested the native api, and it does support partial updates.

However, I think we may need to do more tweaks, if we want to change it to "partial". createCreateOrUpdateRequestBody() is currently written for create/full-update semantics. Also, the current frontend code and tests also rely on full-update semantics. If we want to support partial updates, we will likely need broader changes across the DTOs, request-building logic, and tests, since the current design is aligned around full replacement.

@ChengShi-1 ChengShi-1 moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Apr 3, 2026
@ekraffmiller
Copy link
Copy Markdown
Contributor

Thanks for the PR, it would be a good addition to allow this, since it is allowed on the API.
I agree with @ChengShi-1, the current implementation of createCreateOrUpdateRequestBody() needs to change, to allow for partially populated DTO. Also, a test to show that it update is successful with a partially populated DTO. With those changes, I think it could be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 17 FY26 Sprint 17 (2026-02-11 - 2026-02-25) FY26 Sprint 18 FY26 Sprint 18 (2026-02-25 - 2026-03-11) FY26 Sprint 20 FY26 Sprint 20 (2026-03-26 - 2026-04-08)

Projects

Status: In Review 🔎

Development

Successfully merging this pull request may close these issues.

6 participants